Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework our mdspan implementation #3343

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

miscco
Copy link
Collaborator

@miscco miscco commented Jan 10, 2025

This completely rewrites our mdspan implementation.

It drop a lot of the old workarounds and follows the recent standard changes.

This is especially prominent for submdspan which has been reworked a ton during standardization

This did not yet implement the padded layouts which have been merged recently

I started using C++17 exclusively which hase been soo awesome

Copy link

copy-pr-bot bot commented Jan 10, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@fbusato
Copy link
Contributor

fbusato commented Jan 10, 2025

it seems that the new implementation of submdspan works correctly when the data type of mdspan is const and returns the new mdspan with the right accessor. Anyway, please add a test to check the behavior of the accessor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Replace mdspan implementation with one derived from the newer LLVM implementation
2 participants